Robert Shearman : wininet: Don't duplicate empty strings.
Alexandre Julliard
julliard at wine.codeweavers.com
Fri Mar 10 14:51:46 CST 2006
Module: wine
Branch: refs/heads/master
Commit: ef20936c53b5d593e32b11465e92291e8afae19c
URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ef20936c53b5d593e32b11465e92291e8afae19c
Author: Robert Shearman <rob at codeweavers.com>
Date: Fri Mar 10 12:28:52 2006 +0000
wininet: Don't duplicate empty strings.
---
dlls/wininet/http.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index 156bc64..1a2638c 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -2113,7 +2113,9 @@ static BOOL HTTP_HandleRedirect(LPWININE
HeapFree(GetProcessHeap(), 0, lpwhs->lpszUserName);
- lpwhs->lpszUserName = WININET_strdupW(userName);
+ lpwhs->lpszUserName = NULL;
+ if (userName[0])
+ lpwhs->lpszUserName = WININET_strdupW(userName);
lpwhs->nServerPort = urlComponents.nPort;
INTERNET_SendCallback(&lpwhr->hdr, lpwhr->hdr.dwContext,
@@ -2445,12 +2447,12 @@ HINTERNET HTTP_Connect(LPWININETAPPINFOW
if(hIC->lpszProxyBypass)
FIXME("Proxy bypass is ignored.\n");
}
- if (NULL != lpszServerName)
+ if (lpszServerName && lpszServerName[0])
{
lpwhs->lpszServerName = WININET_strdupW(lpszServerName);
lpwhs->lpszHostName = WININET_strdupW(lpszServerName);
}
- if (NULL != lpszUserName)
+ if (lpszUserName && lpszUserName[0])
lpwhs->lpszUserName = WININET_strdupW(lpszUserName);
lpwhs->nServerPort = nServerPort;
lpwhs->nHostPort = nServerPort;
More information about the wine-cvs
mailing list