wininet [1/2]: Add test for FtpGetCurrentDirectoryA
Dan Kegel
dank at kegel.com
Thu Nov 29 07:49:54 CST 2007
Nice to see you contributing tests!
Three comments:
1. you seem to have ragged indentation. Did you remember to remove all tabs?
(Hmm. Our doc on the tab issue is a bit weak: neither
http://winehq.org/site/sending_patches
http://winehq.org/site/docs/winedev-guide/style-notes
really capture the current anti-tab mood.)
2. You have a nice testDir variable, but then you hard-code
"pub" somewhere. Use the variable everywhere.
3. Did you make sure the new tests pass on Windows?
--
Wine for Windows ISVs: http://kegel.com/wine/isv
More information about the wine-devel
mailing list