Thanks for the suggestion; I didn't realize you could get a pointer to the string itself. Here's an updated patch. I also changed the wording some more to make it less similar to the native dxdiag.<br><br><div class="gmail_quote">
On Sat, Sep 19, 2009 at 12:05 PM, Henri Verbeet <span dir="ltr"><<a href="mailto:hverbeet@gmail.com">hverbeet@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">2009/9/18 Brian Nguyen <<a href="mailto:mtxcoll@gmail.com">mtxcoll@gmail.com</a>>:<br>
</div><div class="im">> Here's an updated patch that stores the string in an En.rc resource file and<br>
> loads it using a wrapper for LoadString. How does this look?<br>
><br>
</div>I think that should work, but how about something like this:<br>
<br>
static const WCHAR *DxDiag_LoadString(UINT id)<br>
{<br>
� �static const WCHAR failed[] = { 'F', 'a', 'i', 'l', 'e', 'd', '!', '\0' };<br>
� �const WCHAR *ret;<br>
<br>
� �if (!LoadStringW(GetModuleHandleW(NULL), id, (WCHAR *)&ret, 0))<br>
� �{<br>
� � � �WINE_FIXME("Failed to load string %u, last error %u.\n",<br>
� � � � � � � �id, GetLastError());<br>
� � � �return failed;<br>
� �}<br>
<br>
� �return ret;<br>
}<br>
<br>
> + � �DXDIAG_MESSAGE_HELP,<br>
You have a trailing space here.<br>
</blockquote></div><br><br clear="all"><br>-- <br>Brian Nguyen<br><a href="mailto:mtxcoll@gmail.com">mtxcoll@gmail.com</a><br>