WINED3D: Remove an incorrect FIXME

H. Verbeet hverbeet at gmail.com
Wed Mar 8 17:52:29 CST 2006


glGetString(GL_PROGRAM_ERROR_STRING_ARB) should be called after
glProgramStringARB, not while drawing a frame. Any errors in the
vertex program should already be dumped in
IWineD3DVertexShaderImpl_GenerateProgramArbHW.

Changelog:
  - Remove an incorrect FIXME
-------------- next part --------------
diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c
index 37d7453..6d0c282 100644
--- a/dlls/wined3d/drawprim.c
+++ b/dlls/wined3d/drawprim.c
@@ -1817,13 +1817,6 @@ UINT numberOfvertices, UINT numberOfIndi
             drawStridedFast(iface, numberOfIndicies, glPrimType,
                         idxData, idxSize, minIndex, StartIdx);
 
-            /* check for any errors */
-            glGetIntegerv( GL_PROGRAM_ERROR_POSITION_ARB, &errPos );
-            if (errPos != -1) {
-                FIXME("HW VertexShader Error at position %d: %s\n",
-                      errPos, debugstr_a((const char *)glGetString(GL_PROGRAM_ERROR_STRING_ARB)));
-            }
-
             /* disable any attribs */
             if(((IWineD3DVertexShaderImpl *)This->stateBlock->vertexShader)->declaredArrays) {
                 GLint maxAttribs;



More information about the wine-patches mailing list