Wine HQ

  WineHQ Menu
  WineHQ
  AppDB
  Bugzilla
  Wine Wiki
  Wine Forums
  About
  Introduction
  Features
  Screenshots
  Contributing
  News Blog
  World Wine News
  Press
  License
  Download
  Get Wine Now
  Support
  Getting Help
  FAQ
  Documentation
  HowTo
  Live Support Chat
  Paid Support
  Development
  Developers Guide
  Mailing Lists
  GIT
  Sending Patches
  To Do Lists
  Fun Projects
  Janitorial
  Winelib
  Status
  Resources
  WineConf
  Languages
English English
Español Español
  Search WineHQ

Coding Practice

Chapter 4. Coding Practice

This chapter describes the relevant coding practices in Wine, that you should be aware of before doing any serious development in Wine.

4.1. Patch Format

Patches are submitted via email to the Wine patches mailing list, . Your patch should include:

  • A meaningful subject (very short description of patch)

  • A long (paragraph) description of what was wrong and what is now better. (recommended)

  • A change log entry (short description of what was changed).

  • The patch in "Git" format

To generate a patch using Git, first commit it to your local tree.

Each file that you change needs to be updated with git update . If you are adding or removing a file, use git update --add or git update --remove respectively. After updating the index, commit the change using git commit . The commit message will be sent with your patch, and recored in the ChangeLog.

After committing the patch, you can extract it using git format-patch and send it to wine-patches using git imap-send or simply attaching it to you mail manually.