Alistair Leslie-Hughes : msvcrt: Implement wcscpy_s.
James Hawkins
truiken at gmail.com
Wed Feb 27 21:17:35 CST 2008
On Wed, Feb 27, 2008 at 9:03 PM, James McKenzie
<jjmckenzie51 at sprintpcs.com> wrote:
> Alexandre Julliard wrote:
> > Module: wine
> > Branch: master
> > Commit: 00609d5e7824a117084f3f4b75e1aec03b60102a
> > URL: http://source.winehq.org/git/wine.git/?a=commit;h=00609d5e7824a117084f3f4b75e1aec03b60102a
> >
> > Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> > Date: Wed Feb 27 19:58:04 2008 +1100
> >
> > msvcrt: Implement wcscpy_s.
> >
> > +
> > + if(size > numElement)
> >
> Is this correct? I think it should be different, maybe if
>
> (size<numElement)?
> > + {
> > + wcDest[0] = 0;
> > + return MSVCRT_EINVAL;
> > + }
> > +
> > + if(size > numElement)
> >
> This and the one above are the same.
>
If you'll read the tests, you'll see that the first test is correct
(although it should really be >= and he should add a test for this).
The second check should be removed completely.
--
James Hawkins
More information about the wine-devel
mailing list