resend: kernel32: modify DeleteFile to fail on directories

Vincent Povirk madewokherd+8cd9 at gmail.com
Thu Aug 28 18:34:55 CDT 2008


I think you should avoid the GetFileAttributes call. It adds extra
steps (including potentially an extra case-insensitive lookup), and
the file attributes could change between that call and NtDeleteFile.

It seems like it should be possible to do this without forcing ntdll
to search for the file multiple times.

Vincent Povirk



On Thu, Aug 28, 2008 at 8:57 AM, Jeff Zaroyko <jeffzaroyko at gmail.com> wrote:
> combining everything in one patch as Paul Vriens suggested, probably
> makes more sense.
>
> -Jeff
>
>
>
>



More information about the wine-devel mailing list